Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging health #677

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Fix hanging health #677

merged 4 commits into from
Feb 4, 2021

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Feb 4, 2021

Did you run make format && make check?

Fixes #674

Changes:

  • Uptime Tracker IP is now properly passed to the VPN client. So client now can establish direct connection to it.

How to test this PR:

  1. Run visor with the hypervisor on the same machine.
  2. Run VPN client.
  3. Try accessing current visor in the list. Page should open with no timeout.

@Darkren Darkren changed the base branch from master to develop February 4, 2021 17:34
jdknives
jdknives approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will test and then merge.

@jdknives jdknives merged commit 44037af into skycoin:develop Feb 4, 2021
@jdknives jdknives mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/health timeouts when hypervisor board runs VPN-client
2 participants
@Darkren @jdknives